Repository navigation
fix(nefd,udmd): Nnef_EventExposure subscribers get TS 29.591 notifications, an old udmd is refreshed, no leading-zero index (#2154) - #2158
parlakisik wants to merge 1 commit into
Conversation
…tions, an old udmd is refreshed, no leading-zero index (#2154) R42 on #2152: - nefd records the northbound API each subscription was made on. A Nnef_EventExposure subscriber is now notified with a TS 29.591 NefEventExposureNotif (notifId; eventNotifs[{event, timeStamp}]) instead of a T8 MonitoringNotification. TS 29.591 defines no cancellation indication, so none is sent to it when the NEF removes its subscription. Both ceilings are documented in nef.md. - Upgrade order: udmd before nefd (CHANGELOG, nef.md). As a fallback, a 400 to the `add /reportingOptions/expiry` refresh (a udmd from before #2133) is retried once with the whole object. - udmd refuses a JSON Pointer array index with a leading zero or a sign (RFC 6901 §4). Spec: specs/nefd-udmd-2152-followups-2154.md
R42 review: #2158 (head a2883d8, Closes #2154)Tested on a2883d8, which is already up to date with origin/main (including the merged #2152). TS 29.591 reading is correct. I checked it against the TS29591_Nnef_EventExposure OpenAPI:
So sending nothing to a TS 29.591 consumer on a NEF-initiated removal, and documenting that ceiling, is the right mapping. Inventing a Verified. Each revert below was a behavioural edit run on its own; I restored each and the tree is clean.
Interaction with #2152 and #2155. #2152 is merged, and this branch already contains it. #2155 (open, approved) conflicts with this PR in minor
VERDICT: APPROVE |
Closes #2154.
These are R42's three follow-ups from the #2152 review.
Verified against main (#2152 merged)
cancelIndbuild_monitoring_notificationandcancellation_notificationnever consult the API, and the subscription records nonestr::parse::<usize>accepts01, and also+1TS 29.591
NefEventExposureNotifis{notifId (M), eventNotifs: [NefEventNotification {event (M), timeStamp (M), ...}] (M)}.NefEventhas no LOCATION_REPORT, UE_REACHABILITY or LOSS_OF_CONNECTIVITY value, but admits a free-form string. Nothing in TS 29.591 carries a cancellation indication.Changes
NefMonitoringSubscription.northbound_apirecords the API a subscription was made on. It defaults to T8 when deserialised, so a record from before nefd/udmd: #2152 follow-ups (29.591 notification shape, udmd-first upgrade order, JSON Pointer leading zeros) #2154 reads as what it was notified in.{notifId: <its notifId>, eventNotifs: [{event: <the eventId it subscribed to>, timeStamp: <the producer's, else now>}]}.add /reportingOptions/expiryrefresh, nefd retries once with the whole-object form, so legs keep being refreshed during a rolling upgrade.0or have no leading zero (RFC 6901 §4). A sign is refused too.Acceptance vs evidence (each revert done on its own, restored, and checked with
diff)a_nnef_subscriber_is_notified_in_the_ts_29_591_shape_2154: the exact NefEventExposureNotif goes to a Nnef subscriber and a T8 body to a T8 one, and LOCATION_REPORTING maps back to LOCATION_REPORT.nnef_event_exposure_subscribe_is_served_...now also asserts that the created subscription recordsNnefEventExposurennef_removals_send_nothing_and_an_old_udm_is_refreshed_2154: the T8 subscriber gets itscancelInd, and the Nnef one gets nothingrefreshed: 0, and the test failsee_patch_refuses_an_array_index_with_a_leading_zero_2154:01,00,+1and1aare refused and change nothing;0and10workstr::parse: the test failsGates (local)
cargo fmt --all --check.--all-targets -D warningsfor udmd and nefd, plus nefd--features demo-d445a-fl-t8.