Skip to content

Make the packaging renderer portable - #2350

Merged
athiwatc merged 1 commit into
mainfrom
codex/render-packaging-portability-2286
Nov 20, 2026
Merged

athiwatc merged 1 commit into
mainfrom
codex/render-packaging-portability-2286

Conversation

@athiwatc

Copy link
Copy Markdown
Owner

Refs #2286.

  • Use sha256sum or shasum -a 256 for source archives. Report the prerequisite before downloading if both are absent.
  • Keep Info-ZIP when available and use Python's standard library when unzip is absent. Require the exact Windows executable member and accept either slash direction.
  • Cover both hashers, both ZIP readers and missing-tool cases in the offline renderer suite.

Validation on exact head 08d5467c80a932e0c28c18460d5c81815282909f:

  • Independent review passed on the equivalent diff before the base advanced. Verified identical blobs for both edited files after rebase.
  • 20 offline renderer, release-check and mock publication tests passed. All 10 renderer tests also passed with Bash 3.2 compatibility mode and spaces in fixture paths.
  • Bash syntax, whitespace, and the renderer tests on the dry combination with Keep prereleases out of stable release channels #2219 passed.

Native macOS Bash and shasum, a PowerShell-produced ZIP and winget installation remain unverified. No release or deployment was run.

@athiwatc
athiwatc marked this pull request as ready for review November 20, 2026 04:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T04:50:22.511084Z 08d5467 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-20T04:51:28.863724Z 08d5467 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@athiwatc
athiwatc merged commit d204569 into main Nov 20, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants