Skip to content

Moving jackson-dataformat-msgpack to this repository #145

Closed

Description

@komamitsu

I'm moving https://github.com/komamitsu/jackson-dataformat-msgpack to this repository in https://github.com/msgpack/msgpack-java/tree/v07-add-jackson-dataformat branch. I copied the original repository to msgpack-jackson directory and modified project/Build.scala so that we can build and test msgpack-jackson.

TODO:

  1. I think we need to update README.md so that it contains information about jackson-dataformat-msgpack and the contents of https://github.com/komamitsu/jackson-dataformat-msgpack/blob/master/README.md.
  2. Also, for deployment, I think jackson-dataformat-msgpack should be released as org.msgpack:jackson-dataformat-msgpack. (Is this possible? @xerial)

But I have no clear ways to do that for now. Any suggestion is welcome!

Activity

  1. xerial commented on Nov 9, 2014

    @xerial
    Member

    For 1., simply add a link to msgpack-jackson/README.md in the msgpack-java/README.md file.

    For 2., as we discussed offline, the release cycle of msgpack-jackson depends on both of msgpack-core and jackson. Having a separate build.sbt script would be easy to manage, that means, creating msgpack-jackson/bild.sbt. If we need to integrate the build process, I can write a sbt script for loading the project in msgpack-jackson subfolder.

    I think msgpack-core/value/jackson should have the same version number for each release.

    For 2. you can use name setting key to deploy jackson-dataformat-msgpack.jar.

  2. xerial commented on Nov 9, 2014

    @xerial
    Member

    msgpack-jackson is a really important component of msgpack-java, so it might be better increment the version number of msgpack-core/value/jackson 0.7.x as a new version of jackson-databind is released.

    It looks like the release cycle of jackson-databind is not so frequent:
    https://github.com/FasterXML/jackson-databind/releases

    To simplify the deployment process, msgpack-core/value/jackson can have the same version number (0.7.x) for each release, and in the release note we should mention this version depends on jackson-databind 2.4.x, etc.

  3. added this to the v07 milestone on Nov 9, 2014
  4. komamitsu commented on Nov 10, 2014

    @komamitsu
    MemberAuthor

    @xerial Thanks for your comments. I fixed some points you commented. Can you review it again?

  5. modified the milestones: 0.7.0-M5, v07 on Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions