Repository navigation
gh-100228: Document the os.fork threads DeprecationWarning. - #109767
Merged
Merged
Conversation
gpshead
marked this pull request as ready for review
September 23, 2023 00:20
AA-Turner
reviewed
Sep 23, 2023
AA-Turner
reviewed
Sep 23, 2023
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
(thanks AA-Turner!)
hugovk
approved these changes
Sep 23, 2023
hugovk
left a comment
Member
There was a problem hiding this comment.
Looks good, couple of suggestions.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
AA-Turner
approved these changes
Sep 23, 2023
gpshead
enabled auto-merge (squash)
September 23, 2023 05:03
commented
Sep 23, 2023
Contributor
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
commented
Sep 23, 2023
|
GH-109773 is a backport of this pull request to the 3.12 branch. |
malemburg
reviewed
Sep 23, 2023
| We added the warning to to raise awareness as issues encounted by code doing | ||
| this are becoming more frequent. See the :func:`os.fork` documentation for | ||
| more details. | ||
|
|
Member
There was a problem hiding this comment.
I would copy the paragraph from the os.fork() docs here as well, to make it easier for people to find the reasoning behind this:
See `this discussion on fork being incompatible with threads
<https://discuss.python.org/t/33555>`_
for technical details of why we're surfacing this longstanding
platform compatibility problem to developers.
Member
Author
There was a problem hiding this comment.
Thanks, I included that (edited) over in the 3.12 backport #109773. I'll make the same edit in main after that is merged.
This was referenced Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better document the os.fork warning to explain questions such as those raised in https://discuss.python.org/t/concerns-regarding-deprecation-of-fork-with-alive-threads/33555.
📚 Documentation preview 📚: https://cpython-previews--109767.org.readthedocs.build/