Repository navigation
Conversation
pablogsal
requested review from
DinoV,
FFY00,
Yhg1s,
brettcannon,
ericsnowcurrently,
kumaraditya303,
ncoghlan and
warsaw
as code owners
November 21, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two namespaces lazily import the same submodule, a later declaration with private builtins can replace the shared entry. Another namespace can then call that declaration's
__import__hook.Use a neutral entry for private builtins mappings, which already resolve the full dotted name through their own hook. The entry cannot replace an ordinary declaration. Direct lazy bindings retain their hook. With only private declarations, shared package access follows the lazy
frompath. That path bypasses__import__for the child request.This addresses the hook-selection case from the discussion on gh-158521, related to gh-158597.