Repository navigation
gh-162219: Provide explicit SIMD defaults for HACL streaming HMAC - #162393
tamaki0575-cloud wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
| @@ -0,0 +1,11 @@ | |||
| /* Compile the HACL* streaming HMAC implementation with explicit SIMD defaults. */ | |||
| #include "_hacl/internal/Hacl_Streaming_HMAC.h" | |||
There was a problem hiding this comment.
I would rather prefer that this file is put in the _hacl folder next to refresh.sh or update the sh script instead if necessary. We already have some namespace hacking for HACL
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
Compile the vendored HACL* streaming HMAC implementation through a CPython wrapper. The wrapper defaults
HACL_CAN_COMPILE_VEC128andHACL_CAN_COMPILE_VEC256to0only when they are undefined. The Makefile and Windows project both use the wrapper, so the vendored source stays untouched.Fixes #162219.
Testing
make Modules/_hacl/Hacl_Streaming_HMAC.o CC='gcc -Wundef'reproduced both warnings before the patch and emitted neither after it.mainat1822ff5and ran./python -m test test_hmac test_hashlib. Both test modules passed (241 tests run, 17 skipped).Codex was used to verify the patch and prepare this PR description.
HACL_CAN_COMPILE_VEC128macro is not defined when building Python with-Wundef#162219