Skip to content

Fix Value#toJson - #2

Merged
xerial merged 1 commit into
xerial:rename-dataaccessfrom
msgpack:fix-to-json
Jul 1, 2015
Merged

xerial merged 1 commit into
xerial:rename-dataaccessfrom
msgpack:fix-to-json

Conversation

@frsyuki

@frsyuki frsyuki commented Jul 1, 2015

Copy link
Copy Markdown

Value#toJson() is expected to return a valid json since its name. Some
valid MessagePack values are invalid in JSON such as ExtensionValue,
non-string keys in a MapValue, NaN or Infinite.

Value#toJson() is expected to return a valid json since its name. Some
valid MessagePack values are invalid in JSON such as ExtensionValue,
non-string keys in a MapValue, NaN or Infinite.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, <p/> is necessary to insert blank lines in Javadoc :)

@xerial

xerial commented Jul 1, 2015

Copy link
Copy Markdown
Owner

Thanks for the fix!

xerial added a commit that referenced this pull request Jul 1, 2015
@xerial
xerial merged commit d00a257 into xerial:rename-dataaccess Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants